Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch generated voice id and add to response #472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fetch generated voice id and add to response #472

wants to merge 1 commit into from

Conversation

AngeloGiacco
Copy link
Collaborator

currently we only return a bytes iterator with no reference to the voice id generated.
now return a tuple of the id string and then a bytes iterator, so sdk users can unpack and use as needed

fixes #345

@AngeloGiacco AngeloGiacco self-assigned this Feb 4, 2025
louisjoecodes
louisjoecodes requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@louisjoecodes louisjoecodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to fix this one upstream as it will be overwritten

is there anything you can tweak in openapi-overrides to replicate this diff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisjoecodes louisjoecodes louisjoecodes requested changes

@lharries lharries Awaiting requested review from lharries

@PaulAsjes PaulAsjes Awaiting requested review from PaulAsjes

Requested changes must be addressed to merge this pull request.

Assignees

@AngeloGiacco AngeloGiacco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ElevenLabs Python Client's voice_generation.generate does not return a generated_voice_id
2 participants
@AngeloGiacco @louisjoecodes